[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 21/21] ui/vnc: silent unuseful OSX clang
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 21/21] ui/vnc: silent unuseful OSX clang warning |
Date: |
Thu, 22 Jun 2017 09:33:20 +0200 |
diff --git a/ui/Makefile.objs b/ui/Makefile.objs
> index 3369451285..08fb573a48 100644
> --- a/ui/Makefile.objs
> +++ b/ui/Makefile.objs
> @@ -6,6 +6,14 @@ vnc-obj-y += vnc-auth-vencrypt.o
> vnc-obj-$(CONFIG_VNC_SASL) += vnc-auth-sasl.o
> vnc-obj-y += vnc-ws.o
> vnc-obj-y += vnc-jobs.o
> +ifeq ($(CONFIG_VNC_SASL),y)
> +# silent OSX SASL warnings (from https://stackoverflow.com/a/7406994
> ):
> +# because OpenSSL doesn’t offer API compatibility between versions,
> [...] Apple
> +# can't provide security updates without breaking existing apps, so
> is migrating
> +# from OpenSSL to Common Crypto.
> +vnc.o-cflags := -Wno-deprecated-declarations
> +vnc-auth-sasl.o-cflags := -Wno-deprecated-declarations
> +endif
Hmm, does clang understand "#pragma GCC diagnostic" ?
If so, then this can be done in in the code not the makefiles, and also
selectively for osx only.
See include/ui/gtk.h for an example.
cheers,
Gerd
- [Qemu-devel] [PATCH v2 15/21] travis: retry when git submodules initialization fails, (continued)
- [Qemu-devel] [PATCH v2 15/21] travis: retry when git submodules initialization fails, Philippe Mathieu-Daudé, 2017/06/21
- [Qemu-devel] [PATCH v2 16/21] travis: split the gprof/gcov job, Philippe Mathieu-Daudé, 2017/06/21
- [Qemu-devel] [PATCH v2 17/21] travis/osx: don't update Homebrew cache, Philippe Mathieu-Daudé, 2017/06/21
- [Qemu-devel] [PATCH v2 18/21] travis/osx: silent texinfo warnings, Philippe Mathieu-Daudé, 2017/06/21
- [Qemu-devel] [PATCH v2 19/21] travis/osx: build using more Xcode versions, Philippe Mathieu-Daudé, 2017/06/21
- [Qemu-devel] [PATCH v2 20/21] MAINTAINERS: self-appoint me as reviewer in build/test automation, Philippe Mathieu-Daudé, 2017/06/21
- [Qemu-devel] [RFC PATCH v2 21/21] ui/vnc: silent unuseful OSX clang warning, Philippe Mathieu-Daudé, 2017/06/21