[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/31] slirp: use DIV_ROUND_UP
From: |
Samuel Thibault |
Subject: |
Re: [Qemu-devel] [PATCH 12/31] slirp: use DIV_ROUND_UP |
Date: |
Fri, 23 Jun 2017 02:19:55 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
Marc-André Lureau, on jeu. 22 juin 2017 14:41:45 +0200, wrote:
> I used the clang-tidy qemu-round check to generate the fix:
> https://github.com/elmarco/clang-tools-extra
>
> Signed-off-by: Marc-André Lureau <address@hidden>
Applied to my tree, thanks!
> ---
> slirp/ip6.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/slirp/ip6.h b/slirp/ip6.h
> index 0908855f0f..b1bea43b3c 100644
> --- a/slirp/ip6.h
> +++ b/slirp/ip6.h
> @@ -57,9 +57,9 @@ static inline bool in6_equal_mach(const struct in6_addr *a,
> const struct in6_addr *b,
> int prefix_len)
> {
> - if (memcmp(&(a->s6_addr[(prefix_len + 7) / 8]),
> - &(b->s6_addr[(prefix_len + 7) / 8]),
> - 16 - (prefix_len + 7) / 8) != 0) {
> + if (memcmp(&(a->s6_addr[DIV_ROUND_UP(prefix_len, 8)]),
> + &(b->s6_addr[DIV_ROUND_UP(prefix_len, 8)]),
> + 16 - DIV_ROUND_UP(prefix_len, 8)) != 0) {
> return 0;
> }
>
> --
> 2.13.1.395.gf7b71de06
>
--
Samuel
<D> N: j'aime bien Cut d'un truc enorme... ca montre de quel cote de l'ecran
sont les gonades :)))
-+- #ens-mim et la peufeupeu -+-
- [Qemu-devel] [PATCH 04/31] vhost: use QEMU_ALIGN_DOWN, (continued)
- [Qemu-devel] [PATCH 04/31] vhost: use QEMU_ALIGN_DOWN, Marc-André Lureau, 2017/06/22
- [Qemu-devel] [PATCH 05/31] i8254: use QEMU_ALIGN_DOWN, Marc-André Lureau, 2017/06/22
- [Qemu-devel] [PATCH 06/31] pcspk: use QEMU_ALIGN_DOWN, Marc-André Lureau, 2017/06/22
- [Qemu-devel] [PATCH 07/31] dmg: use DIV_ROUND_UP, Marc-André Lureau, 2017/06/22
- [Qemu-devel] [PATCH 08/31] qcow2: use DIV_ROUND_UP, Marc-André Lureau, 2017/06/22
- [Qemu-devel] [PATCH 09/31] vpc: use DIV_ROUND_UP, Marc-André Lureau, 2017/06/22
- [Qemu-devel] [PATCH 10/31] vvfat: use DIV_ROUND_UP, Marc-André Lureau, 2017/06/22
- [Qemu-devel] [PATCH 11/31] vnc: use DIV_ROUND_UP, Marc-André Lureau, 2017/06/22
- [Qemu-devel] [PATCH 12/31] slirp: use DIV_ROUND_UP, Marc-André Lureau, 2017/06/22
- Re: [Qemu-devel] [PATCH 12/31] slirp: use DIV_ROUND_UP,
Samuel Thibault <=
- [Qemu-devel] [PATCH 13/31] ui: use DIV_ROUND_UP, Marc-André Lureau, 2017/06/22
- [Qemu-devel] [PATCH 14/31] vga: use DIV_ROUND_UP, Marc-André Lureau, 2017/06/22
- [Qemu-devel] [PATCH 15/31] virtio-gpu: use DIV_ROUND_UP, Marc-André Lureau, 2017/06/22
- [Qemu-devel] [PATCH 16/31] monitor: use DIV_ROUND_UP, Marc-André Lureau, 2017/06/22
- [Qemu-devel] [PATCH 17/31] console: use DIV_ROUND_UP, Marc-André Lureau, 2017/06/22
- [Qemu-devel] [PATCH 18/31] virtio-serial: use DIV_ROUND_UP, Marc-André Lureau, 2017/06/22
- [Qemu-devel] [PATCH 19/31] piix: use DIV_ROUND_UP, Marc-André Lureau, 2017/06/22
- [Qemu-devel] [PATCH 20/31] q35: use DIV_ROUND_UP, Marc-André Lureau, 2017/06/22
- [Qemu-devel] [PATCH 21/31] usb-hub: use DIV_ROUND_UP, Marc-André Lureau, 2017/06/22
- [Qemu-devel] [PATCH 22/31] msix: use DIV_ROUND_UP, Marc-André Lureau, 2017/06/22