[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 1/2] arm/highbank: use defined type name ins
From: |
John Snow |
Subject: |
Re: [Qemu-devel] [RFC PATCH 1/2] arm/highbank: use defined type name instead of hard-coded string |
Date: |
Fri, 23 Jun 2017 18:18:55 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 06/09/2017 11:05 AM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/arm/highbank.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c
> index d209b97dee..dd809b404b 100644
> --- a/hw/arm/highbank.c
> +++ b/hw/arm/highbank.c
> @@ -31,6 +31,7 @@
> #include "exec/address-spaces.h"
> #include "qemu/error-report.h"
> #include "hw/char/pl011.h"
> +#include "hw/ide/ahci.h"
>
> #define SMP_BOOT_ADDR 0x100
> #define SMP_BOOT_REG 0x40
> @@ -341,7 +342,7 @@ static void calxeda_init(MachineState *machine, enum
> cxmachines machine_id)
> sysbus_create_simple("pl031", 0xfff35000, pic[19]);
> sysbus_create_simple("pl022", 0xfff39000, pic[23]);
>
> - sysbus_create_simple("sysbus-ahci", 0xffe08000, pic[83]);
> + sysbus_create_simple(TYPE_SYSBUS_AHCI, 0xffe08000, pic[83]);
>
> if (nd_table[0].used) {
> qemu_check_nic_model(&nd_table[0], "xgmac");
>
This patch is fine, I took a stab at fixing the include issues in a
separate series. Try it all out and let me know.
--js