[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH RFC v3 6/8] block: add options para
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH RFC v3 6/8] block: add options parameter to bdrv_new_open_driver() |
Date: |
Mon, 26 Jun 2017 16:11:54 +0100 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Fri, Jun 23, 2017 at 03:46:58PM +0300, Manos Pitsidianakis wrote:
> diff --git a/block.c b/block.c
> index 694396281b..c7d9f8959a 100644
> --- a/block.c
> +++ b/block.c
> @@ -1150,20 +1150,25 @@ free_and_fail:
> }
>
> BlockDriverState *bdrv_new_open_driver(BlockDriver *drv, const char
> *node_name,
> - int flags, Error **errp)
> + int flags, QDict *options, Error
> **errp)
Please add a doc comment that explains the QDict ownership when options
!= NULL. Users need to understand whether the options QDict still
belongs to them after the call or bdrv_new_open_driver() takes over
ownership.
See bdrv_open_inherit() for an example.
signature.asc
Description: PGP signature