Re: [Qemu-devel] [PATCH] configure: Handle having no c++ compiler in FORTIFY_SOURCE check

[Philippe Mathieu-Daudé]

On 06/26/2017 12:25 PM, Peter Maydell wrote:
> Our FORTIFY_SOURCE check assumes that $cxx refers to a working C++
> compiler, with the result that if you don't happen to have one
> then configure will spuriously print
>    configure: line 4685: c++: command not found
>
> Fix this by adding a 'has $cxx' check.
>
> Signed-off-by: Peter Maydell <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>   configure | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index c571ad1..a435908 100755
> --- a/configure
> +++ b/configure
> @@ -4681,7 +4681,7 @@ fi
>   if test "$fortify_source" != "no"; then
>     if echo | $cc -dM -E - | grep __clang__ > /dev/null 2>&1 ; then
>       fortify_source="no";
> -  elif test -n "$cxx" &&
> +  elif test -n "$cxx" && has $cxx &&
>          echo | $cxx -dM -E - | grep __clang__ >/dev/null 2>&1 ; then
>       fortify_source="no";
>     else