[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/5] qemu-iotests: 068: extract _qemu() function
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 3/5] qemu-iotests: 068: extract _qemu() function |
Date: |
Tue, 27 Jun 2017 06:40:04 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 06/15/2017 11:38 AM, Stefan Hajnoczi wrote:
> Avoid duplicating the QEMU command-line.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> tests/qemu-iotests/068 | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> +# Give qemu some time to boot before saving the VM state
> +bash -c 'sleep 1; echo -e "savevm 0\nquit"' | _qemu
Are we sure that 'bash' on PATH is the same as the /bin/bash running the
script?
Also, while bash has more deterministic behavior for 'echo -e' (it is
non-portable if you are porting a script to other shells), it is still
possible to set bash to a mode where it does not work (see xhopt
xpg_echo). I'd much prefer you use 'printf' instead of 'set -e'.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 1/5] virtio-pci: use ioeventfd even when KVM is disabled, (continued)
[Qemu-devel] [PATCH 2/5] migration: hold AioContext lock for loadvm qemu_fclose(), Stefan Hajnoczi, 2017/06/15
[Qemu-devel] [PATCH 3/5] qemu-iotests: 068: extract _qemu() function, Stefan Hajnoczi, 2017/06/15
[Qemu-devel] [PATCH 4/5] qemu-iotests: 068: use -drive/-device instead of -hda, Stefan Hajnoczi, 2017/06/15
[Qemu-devel] [PATCH 5/5] qemu-iotests: 068: test iothread mode, Stefan Hajnoczi, 2017/06/15
Re: [Qemu-devel] [PATCH 0/5] qemu-iotests: test savevm/loadvm iothread (and make it work!), Stefan Hajnoczi, 2017/06/15
Re: [Qemu-devel] [PATCH 0/5] qemu-iotests: test savevm/loadvm iothread (and make it work!), Pavel Butsykin, 2017/06/19