[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qde
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev |
Date: |
Tue, 27 Jun 2017 11:47:18 -0300 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Tue, Jun 27, 2017 at 12:10:13PM +0800, Peter Xu wrote:
[...]
> +
> +static const TypeInfo migration_type = {
> + .name = TYPE_MIGRATION,
> + .parent = TYPE_DEVICE,
As TYPE_MIGRATION isn't really a device and we're using TYPE_DEVICE just
to reuse the global property system, maybe we should add a comment here
explaining that?
It would also be interesting to explain the TYPE_DEVICE features we do
not use. e.g.: the device is not created using qdev_create(), it is
never attached to any bus, and it is never realized.
(But I don't think this should require a series respin. The comment may
be sent as a follow-up patch.)
> + .class_init = migration_class_init,
> + .class_size = sizeof(MigrationClass),
> + .instance_size = sizeof(MigrationState),
> + .instance_init = migration_instance_init,
> +};
> +
[...]
--
Eduardo
- [Qemu-devel] [PATCH v6 00/10] migration: objectify MigrationState, Peter Xu, 2017/06/27
- [Qemu-devel] [PATCH v6 02/10] accel: introduce AccelClass.global_props, Peter Xu, 2017/06/27
- [Qemu-devel] [PATCH v6 03/10] vl: clean up global property registerations, Peter Xu, 2017/06/27
- [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev, Peter Xu, 2017/06/27
- Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev,
Eduardo Habkost <=
- Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev, Eduardo Habkost, 2017/06/27
- Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev, Max Reitz, 2017/06/29
- Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev, Peter Xu, 2017/06/29
- Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev, Peter Xu, 2017/06/30
- Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev, Max Reitz, 2017/06/30
- Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev, Eric Blake, 2017/06/30
- Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev, Max Reitz, 2017/06/30
[Qemu-devel] [PATCH v6 05/10] migration: move global_state.optional out, Peter Xu, 2017/06/27