|
From: | Lluís Vilanova |
Subject: | Re: [Qemu-devel] [PATCH v9 06/26] target: [tcg, i386] Port to DisasContextBase |
Date: | Wed, 28 Jun 2017 14:23:07 +0300 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Emilio G Cota writes: > On Sun, Jun 25, 2017 at 12:07:57 +0300, Lluís Vilanova wrote: >> Incrementally paves the way towards using the generic instruction translation >> loop. >> >> Signed-off-by: Lluís Vilanova <address@hidden> > Just a minor nit: the commit titles are a little strange to me. > I'd rather do: "target/arch: foo" than "target: [tcg, arch]: foo" -- > it's less characters ("tcg" is redundant) and seems more in line with > qemu's idioms. Is tcg redundant? I thought it was necessary for differentiating it from the kvm target-specific parts. Cheers, Lluis
[Prev in Thread] | Current Thread | [Next in Thread] |