[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1] virtio-net: code cleanup
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v1] virtio-net: code cleanup |
Date: |
Wed, 28 Jun 2017 08:02:06 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
[meta-comment, replacing virtio-dev with virtio-dev-owner in cc]
On 06/28/2017 07:22 AM, Eric Blake wrote:
> On 06/28/2017 12:53 AM, Wei Wang wrote:
>> Use is_power_of_2(), and remove trailing "." from error_setg().
>>
>> Signed-off-by: Wei Wang <address@hidden>
>> ---
>> hw/net/virtio-net.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> Reviewed-by: Eric Blake <address@hidden>
>
I got this rejection letter:
>
> The mail system
>
> <address@hidden>: permission denied. Command output: Sorry,
> only subscribers may post. If you are a subscriber, please forward this
> message to address@hidden to get your new address
> included (#5.7.2) ERROR: postqmail-local Error #77
It's generally considered poor netiquette to cc both an open list and a
closed list that rejects emails from non-subscribers (note that you do
NOT have to subscribe to qemu-devel to post to it, although a moderation
delay may be involved). It's not necessarily my place to tell the
virtio-dev list what to do (since I don't subscribe), but it may be
worth considereing relaxing the list posting policies there to allow
moderated posts from non-subscribers, especially if it is going to be
common-place that people want to cc virtio-dev at the same time as
another open list.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature