[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 09/10] migration: merge enforce_config_sectio
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH v6 09/10] migration: merge enforce_config_section somewhat |
Date: |
Thu, 29 Jun 2017 00:42:56 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Eduardo Habkost <address@hidden> wrote:
>
> So, this is a case where a user-provided config option (-machine
> enforce-config-section) should trigger a different default in another
> class (migration.send-configuration).
>
> Also, the new default triggered by -machine has a very specific
> priority:
>
> * AccelClass::global_props must not override "-machine
> enforce-config-section=on"
> * MachineClass::compat_props must not override
> "-machine enforce-config-section=on"
>
> We must also decide in advance what should be result of:
> * "-machine enforce-config-section=on -global
> migration.send-configuration=off"
> * "-machine enforce-config-section=off -global
> migration.send-configuration=on"
> * "-global migration.send-configuration=off -machine
> enforce-config-section=off"
> * "-global migration.send-configuration=on -machine enforce-config-section=on"
BOOM!!!!!
We use old configuration or new one.
>
> I'm not sure what we should decide about these 4 cases above, but I
> believe it would be safer to encode that decision at the same place we
> handle the priority between accel/machine/user globals:
> register_global_properties() at vl.c.
>
>
> Or maybe this extra complexity is a sign that we shouldn't try to add
> extra magic to make -machine affect the "migration" object properties,
> and keep the existing machine->enforce_config_section check in the
> migration code? I'm not sure.
Not sure there either. I preffer doing it in a single place, but I am
not the expert here.
Later, Juan.
- Re: [Qemu-devel] [PATCH v6 06/10] migration: move only_migratable to MigrationState, (continued)
Re: [Qemu-devel] [PATCH v6 06/10] migration: move only_migratable to MigrationState, Eduardo Habkost, 2017/06/28
[Qemu-devel] [PATCH v6 07/10] migration: move skip_configuration out, Peter Xu, 2017/06/27
[Qemu-devel] [PATCH v6 08/10] migration: move skip_section_footers, Peter Xu, 2017/06/27
[Qemu-devel] [PATCH v6 09/10] migration: merge enforce_config_section somewhat, Peter Xu, 2017/06/27
[Qemu-devel] [PATCH v6 10/10] migration: hmp: dump globals, Peter Xu, 2017/06/27
[Qemu-devel] [PATCH v6 11/10] migration: add comment for TYPE_MIGRATE, Peter Xu, 2017/06/28