Re: [Qemu-devel] [PATCH v2] Add chardev-send-break monitor command

[Marc-André Lureau]

On Tue, Jun 27, 2017 at 9:46 PM Eric Blake <address@hidden> wrote:

> On 06/11/2017 02:48 AM, Stefan Fritsch wrote:
> > Sending a break on a serial console can be useful for debugging the
> > guest. But not all chardev backends support sending breaks (only telnet
> > and mux do). The chardev-send-break command allows to send a break even
> > if using other backends.
> >
> > Signed-off-by: Stefan Fritsch <address@hidden>
> > Acked-by: Dr. David Alan Gilbert <address@hidden>
>

Looks good to me,
 Reviewed-by: Marc-André Lureau <address@hidden>


> ---
> > v2: added tests and Acked-by line
> >
>
> > +++ b/hmp-commands.hx
> > @@ -1745,6 +1745,22 @@ Removes the chardev @var{id}.
> >  ETEXI
> >
> >      {
> > +        .name       = "chardev-send-break",
> > +        .args_type  = "id:s",
> > +        .params     = "id",
> > +        .help       = "send break on chardev",
>
> Compare this wording,...
>
> > +STEXI
> > address@hidden chardev-send-break id
> > address@hidden chardev-send-break
> > +Sends break on the chardev @var{id}.
>
> repeated here,
>
> > +++ b/qapi-schema.json
> > @@ -5114,6 +5114,26 @@
> >  { 'command': 'chardev-remove', 'data': {'id': 'str'} }
> >
> >  ##
> > +# @chardev-send-break:
> > +#
> > +# Send a break to a character device
>
> ...with this wording.  I like 'send a break' better than 'send break',
> but even better might be 'send a break sequence' or even 'emulate a
> break sequence' (by definition, a break is NOT a character, but on bare
> metal character devices it IS a defined electrical sequence distinct
> from characters to make the recipient aware that the sender is trying to
> get attention).
>
> Otherwise, the patch looks fine to me.  If all that changes is some
> word-smithing (and the maintainer may be willing to do that), you can add:
> Reviewed-by: Eric Blake <address@hidden>
>

Paolo would you take it (perhaps on the next iteration)?

thanks
-- 
Marc-André Lureau