[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/6] nbd/server: add errp to nbd_send_reply()
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/6] nbd/server: add errp to nbd_send_reply() |
Date: |
Thu, 29 Jun 2017 14:31:06 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 06/21/2017 10:34 AM, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> nbd/server.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> @@ -1266,8 +1267,8 @@ reply:
> local_err = NULL;
> }
>
> - if (nbd_co_send_reply(req, &reply, reply_data_len) < 0) {
> - error_setg(&local_err, "Failed to send reply");
> + if (nbd_co_send_reply(req, &reply, reply_data_len, &local_err) < 0) {
> + error_prepend(&local_err, "Failed to send reply: ");
> goto disconnect;
Again, I'm not sure if the error_prepend is necessary vs. just directly
reusing the error from earlier in the stack. But it's not enough to
stop me from giving:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 5/6] nbd/client: refactor TRACE of NBD_MAGIC, (continued)
- [Qemu-devel] [PATCH v2 5/6] nbd/client: refactor TRACE of NBD_MAGIC, Vladimir Sementsov-Ogievskiy, 2017/06/21
- [Qemu-devel] [PATCH v2 4/6] nbd/common: nbd_tls_handshake: remove extra TRACE, Vladimir Sementsov-Ogievskiy, 2017/06/21
- [Qemu-devel] [PATCH v2 2/6] nbd/server: use errp instead of LOG, Vladimir Sementsov-Ogievskiy, 2017/06/21
- [Qemu-devel] [PATCH v2 6/6] nbd: use generic trace subsystem instead of TRACE macro, Vladimir Sementsov-Ogievskiy, 2017/06/21
- [Qemu-devel] [PATCH v2 1/6] nbd/server: nbd_negotiate: return 1 on NBD_OPT_ABORT, Vladimir Sementsov-Ogievskiy, 2017/06/21
- [Qemu-devel] [PATCH v2 3/6] nbd/server: add errp to nbd_send_reply(), Vladimir Sementsov-Ogievskiy, 2017/06/21
- Re: [Qemu-devel] [PATCH v2 3/6] nbd/server: add errp to nbd_send_reply(),
Eric Blake <=