Re: [Qemu-devel] [PATCH 18/22] target/i386: split cpu_set_mxcsr() and make cpu_set_fpuc() inline

[Richard Henderson]

On 07/03/2017 09:34 AM, Paolo Bonzini wrote:
> +static inline void cpu_set_mxcsr(CPUX86State *env, uint32_t mxcsr)
> +{
> +    env->mxcsr = mxcsr;
> +    if (tcg_enabled()) {
> +        tcg_update_mxcsr(env);

I'd prefer update_mxcsr_status for this new name.

> +    }
> +}
> +
> +static inline void cpu_set_fpuc(CPUX86State *env, uint16_t fpuc)
> +{
> +     env->fpuc = fpuc;
> +     if (tcg_enabled()) {
> +        update_fp_status(env);
> +     }
> +}

to match this, and to avoid the implication that it's a function in tcg/.


r~