Re: [Qemu-devel] [PATCH v2 0/4] xen: don't save/restore the physmap on VM save/restore

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PATCH v2 0/4] xen: don't save/restore the physmap on VM 
save/restore

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
c5f49bf xen: don't use xenstore to save/restore physmap anymore
da3fc1b xen/mapcache: introduce xen_replace_cache_entry()
e9069c8 xen/mapcache: add an ability to create dummy mappings
dfbd8c6 xen: move physmap saving into a separate function

=== OUTPUT BEGIN ===
Checking PATCH 1/4: xen: move physmap saving into a separate function...
Checking PATCH 2/4: xen/mapcache: add an ability to create dummy mappings...
ERROR: spaces required around that '|' (ctx:VxV)
#52: FILE: hw/i386/xen/xen-mapcache.c:185:
+                                           PROT_READ|PROT_WRITE,
                                                     ^

ERROR: spaces required around that '|' (ctx:VxV)
#64: FILE: hw/i386/xen/xen-mapcache.c:197:
+        vaddr_base = mmap(NULL, size, PROT_READ|PROT_WRITE,
                                                ^

ERROR: spaces required around that '|' (ctx:VxV)
#65: FILE: hw/i386/xen/xen-mapcache.c:198:
+                          MAP_ANON|MAP_SHARED, -1, 0);
                                   ^

total: 3 errors, 0 warnings, 82 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/4: xen/mapcache: introduce xen_replace_cache_entry()...
ERROR: spaces required around that '|' (ctx:VxV)
#80: FILE: hw/i386/xen/xen-mapcache.c:188:
+                                           PROT_READ|PROT_WRITE, 0,
                                                     ^

ERROR: spaces required around that '|' (ctx:VxV)
#93: FILE: hw/i386/xen/xen-mapcache.c:200:
+        vaddr_base = mmap(vaddr, size, PROT_READ|PROT_WRITE,
                                                 ^

WARNING: line over 80 characters
#162: FILE: hw/i386/xen/xen-mapcache.c:521:
+    while (entry && !(entry->paddr_index == address_index && entry->size == 
cache_size)) {

ERROR: line over 90 characters
#166: FILE: hw/i386/xen/xen-mapcache.c:525:
+        DPRINTF("Trying to update an entry for %lx that is not in the 
mapcache!\n", phys_addr);

WARNING: line over 80 characters
#173: FILE: hw/i386/xen/xen-mapcache.c:532:
+    xen_remap_bucket(entry, entry->vaddr_base, cache_size, address_index, 
false);

ERROR: space required before the open parenthesis '('
#174: FILE: hw/i386/xen/xen-mapcache.c:533:
+    if(!test_bits(address_offset >> XC_PAGE_SHIFT,

WARNING: line over 80 characters
#177: FILE: hw/i386/xen/xen-mapcache.c:536:
+        DPRINTF("Unable to update an entry for %lx in the mapcache!\n", 
phys_addr);

WARNING: line over 80 characters
#184: FILE: hw/i386/xen/xen-mapcache.c:543:
+uint8_t *xen_replace_cache_entry(hwaddr old_phys_addr, hwaddr new_phys_addr, 
hwaddr size)

total: 4 errors, 4 warnings, 192 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/4: xen: don't use xenstore to save/restore physmap anymore...
ERROR: space prohibited between function name and open parenthesis '('
#47: FILE: hw/i386/xen/xen-hvm.c:380:
+    physmap = g_malloc(sizeof (XenPhysmap));

total: 1 errors, 0 warnings, 98 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden