Re: [Qemu-devel] [PATCH v1 4/6] char-socket: Report TCP socket waiting as information

[Philippe Mathieu-Daudé]

On 07/06/2017 08:49 PM, Alistair Francis wrote:
> When QEMU is waiting for a TCP socket connection it reports that message as
> an error. This isn't an error it is just information so let's change the
> report to use info_report() instead.
>
> Signed-off-by: Alistair Francis <address@hidden>
> Reviewed-by: Thomas Huth <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>
>   chardev/char-socket.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/chardev/char-socket.c b/chardev/char-socket.c
> index ccc499cfa1..a050a686ea 100644
> --- a/chardev/char-socket.c
> +++ b/chardev/char-socket.c
> @@ -765,8 +765,8 @@ static int tcp_chr_wait_connected(Chardev *chr, Error 
> **errp)
>        * in TLS and telnet cases, only wait for an accepted socket */
>       while (!s->ioc) {
>           if (s->is_listen) {
> -            error_report("QEMU waiting for connection on: %s",
> -                         chr->filename);
> +            info_report("QEMU waiting for connection on: %s",
> +                        chr->filename);
>               qio_channel_set_blocking(QIO_CHANNEL(s->listen_ioc), true, NULL);
>               tcp_chr_accept(QIO_CHANNEL(s->listen_ioc), G_IO_IN, chr);
>               qio_channel_set_blocking(QIO_CHANNEL(s->listen_ioc), false, NULL);