Re: [Qemu-devel] [PATCH v2 14/45] tcg: define CF_PARALLEL and use it for TB hashing

[Richard Henderson]

On 07/16/2017 10:03 AM, Emilio G. Cota wrote:
> +/* mask cflags for hashing/comparison */
> +static inline uint32_t mask_cf(uint32_t cflags)
> +{
> +    uint32_t mask = 0;
> +
> +    mask |= CF_PARALLEL;
> +    return cflags & mask;
> +}

Surely we don't need a function for this, just a define near all the other CF_ 
definitions.

> +
> +/* current cflags, masked for hashing/comparison */
> +static inline uint32_t curr_cf_mask(void)
> +{
> +    uint32_t val = 0;
> +
> +    if (parallel_cpus) {
> +        val |= CF_PARALLEL;
> +    }
> +    return val;
> +}

Better as curr_cflags?  What's the "mask" part of this?

Also, let's write this more directly, e.g.

  return parallel_cpus ? CF_PARALLEL : 0;

until we have something more to put here.


r~