Re: [Qemu-devel] [PULL 34/40] s390x/cpumodel: wire up new hardware features

[David Hildenbrand]

On 17.07.2017 20:14, Christian Borntraeger wrote:
> On 07/17/2017 07:30 PM, David Hildenbrand wrote:
>> On 14.07.2017 12:41, Christian Borntraeger wrote:
>>> From: "Jason J. Herne" <address@hidden>
>>>
>>> Some new guest features have been introduced recently. Let's wire
>>> them up in the CPU model.
>>>
>>> Signed-off-by: Jason J. Herne <address@hidden>
>>> Acked-by: Christian Borntraeger <address@hidden>
>>> Acked-by: Cornelia Huck <address@hidden>
>>> Signed-off-by: Christian Borntraeger <address@hidden>
>>> [split patch]
>>> ---
>>
>> Would it make sense to add further checks to check_consistency?
>>
>> I think e.g. vx extensions should rely on vx. I can't see a new PoP out
>> there, so I can't check.
> 
> Yes, the vx extensions depend on vx and it makes sense to have a dependeny for
> both extension.

Just realized that I missed these checks, they are already properly in
place :)


-- 

Thanks,

David