Re: [Qemu-devel] [PATCH 03/11] qemu.py: Use iteritems rather than keys()

[Philippe Mathieu-Daudé]

On 07/20/2017 01:28 PM, Lukáš Doktor wrote:
> Let's avoid creating an in-memory list of keys and query for each value
> and use `iteritems` which is an iterator of key-value pairs.
>
> Signed-off-by: Lukáš Doktor <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>   scripts/qemu.py | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/qemu.py b/scripts/qemu.py
> index 66fd863..7e95c25 100644
> --- a/scripts/qemu.py
> +++ b/scripts/qemu.py
> @@ -185,11 +185,11 @@ class QEMUMachine(object):
>       def qmp(self, cmd, conv_keys=True, **args):
>           '''Invoke a QMP command and return the result dict'''
>           qmp_args = dict()
> -        for key in args.keys():
> +        for key, value in args.iteritems():
>               if conv_keys:
> -                qmp_args[key.translate(self.underscore_to_dash)] = args[key]
> +                qmp_args[key.translate(self.underscore_to_dash)] = value
>               else:
> -                qmp_args[key] = args[key]
> +                qmp_args[key] = value
>   
>           return self._qmp.cmd(cmd, args=qmp_args)
>