[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-iotests: add a "how to" to ./
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-iotests: add a "how to" to ./README |
Date: |
Wed, 26 Jul 2017 12:50:37 +0100 |
On 26 July 2017 at 12:33, Stefan Hajnoczi <address@hidden> wrote:
> On Tue, Jul 25, 2017 at 04:34:19PM +0100, Peter Maydell wrote:
>> On 25 July 2017 at 16:20, Stefan Hajnoczi <address@hidden> wrote:
>> > On Mon, Jul 24, 2017 at 11:20:44AM +0100, Peter Maydell wrote:
>> >> Should ./check be run from the source tree, or the build tree? The
>> >> existing README text doesn't say and I don't think your additions
>> >> do either.
>> >
>> > It doesn't matter, both should work. The script detects both
>> > possibilities and rejigs itself to compensate.
>>
>> Does that mean
>> if you run it from the source tree in a tree configured
>> for out of tree build it will:
>> (a) pollute your source tree with test output and binaries
>> (b) give you a helpful message about what to do
>> (c) magically find the build tree somehow
>> (d) not need to write any binaries/test output/temp files at all
>>
>> ?
>
> I think it would fail since the binaries would be missing in the source
> tree.
That sounds like "the README should say you need to run it
from the build tree", then ?
thanks
-- PMM
- Re: [Qemu-devel] [PATCH] qemu-iotests: add a "how to" to ./README, (continued)
- Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-iotests: add a "how to" to ./README, Manos Pitsidianakis, 2017/07/22
- Re: [Qemu-devel] [PATCH] qemu-iotests: add a "how to" to ./README, Kevin Wolf, 2017/07/24
- Re: [Qemu-devel] [PATCH] qemu-iotests: add a "how to" to ./README, Peter Maydell, 2017/07/24
- Re: [Qemu-devel] [PATCH] qemu-iotests: add a "how to" to ./README, Eric Blake, 2017/07/24
- Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-iotests: add a "how to" to ./README, Jeff Cody, 2017/07/26