Re: [Qemu-devel] [PATCH 4/5] ui: add multimedia keys

[Eric Blake]

On 07/26/2017 07:08 AM, Daniel P. Berrange wrote:
> On Wed, Jul 26, 2017 at 07:02:48AM -0500, Eric Blake wrote:
>> On 07/26/2017 06:56 AM, Gerd Hoffmann wrote:
>>> Add multimedia keys to QKeyCodes and to the keymaps.
>>>
>>> Signed-off-by: Gerd Hoffmann <address@hidden>
>>> ---
>>>  ui/input-keymap.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
>>>  qapi-schema.json  | 17 ++++++++++++++++-
>>>  2 files changed, 60 insertions(+), 1 deletion(-)

>>> +# @ac_*: since 2.10
>>
>> Borderline between bug-fix and new feature (arguing that the bug is that
>> we don't represent all keys).  Does this need to be 2.11 instead?
> 
> It is really fixing a bug introduced in the PS2 driver in 2.8.0.  It
> roundtrips via QKeyCode now, so any key where there is an AT Set 1
> scancode defined, but for which we lack a QKeyCode can't be sent to
> guests since QEMU 2.8.0 onwards.

Sounds good to me, although that would be worth mentioning in the commit
message.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature