Re: [Qemu-devel] [PATCH for-2.10 2/2] target/s390x: Fix CSST for 16-byte store

[Philippe Mathieu-Daudé]

On 07/28/2017 03:50 PM, Richard Henderson wrote:
> Found by Coverity.

"Found by Coverity (CID 1378273)."

> Reported-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>   target/s390x/mem_helper.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c
> index cdc78aa3d4..c71dce4b1e 100644
> --- a/target/s390x/mem_helper.c
> +++ b/target/s390x/mem_helper.c
> @@ -1580,6 +1580,7 @@ uint32_t HELPER(csst)(CPUS390XState *env, uint32_t r3, 
> uint64_t a1, uint64_t a2)
>                   cpu_stq_data_ra(env, a2 + 0, svh, ra);
>                   cpu_stq_data_ra(env, a2 + 8, svl, ra);
>               }
> +            break;
>           default:
>               g_assert_not_reached();
>           }