[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 4/9] s390x/pci: do not advertise pci on non-p
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-devel] [PATCH v4 4/9] s390x/pci: do not advertise pci on non-pci builds |
Date: |
Fri, 4 Aug 2017 15:21:41 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 04.08.2017 13:29, Cornelia Huck wrote:
> Only set the zpci feature bit on builds that actually support pci.
>
> Signed-off-by: Cornelia Huck <address@hidden>
> ---
> target/s390x/kvm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c
> index c4c5791d27..bc62bba5b7 100644
> --- a/target/s390x/kvm.c
> +++ b/target/s390x/kvm.c
> @@ -2662,7 +2662,9 @@ void kvm_s390_get_host_cpu_model(S390CPUModel *model,
> Error **errp)
> }
>
> /* We emulate a zPCI bus and AEN, therefore we don't need HW support */
> - set_bit(S390_FEAT_ZPCI, model->features);
> + if (pci_available) {
> + set_bit(S390_FEAT_ZPCI, model->features);
> + }
> set_bit(S390_FEAT_ADAPTER_EVENT_NOTIFICATION, model->features);
>
> if (s390_known_cpu_type(cpu_type)) {
>
Yup, looks good to me.
Reviewed-by: David Hildenbrand <address@hidden>
--
Thanks,
David
[Qemu-devel] [PATCH v4 9/9] s390x: refine pci dependencies, Cornelia Huck, 2017/08/04