[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.11 1/5] qmp-shell: Use argparse module
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH for-2.11 1/5] qmp-shell: Use argparse module |
|
Date: |
Tue, 8 Aug 2017 11:07:21 +0100 |
|
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Fri, Aug 04, 2017 at 06:36:21PM -0300, Eduardo Habkost wrote:
> It makes command-line parsing and generation of help text much
> simpler.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> scripts/qmp/qmp-shell | 61
> +++++++++++++++++----------------------------------
> 1 file changed, 20 insertions(+), 41 deletions(-)
The minimum Python version is 2.6. The argparse module was introduced
in Python 2.7 so we cannot use it without increasing the minimum Python
version:
https://docs.python.org/2.6/modindex.html
I suggest holding off on this for now.
Stefan
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH for-2.11 0/5] qmp-shell non-interactive mode, delete scripts/qmp/qmp, Eduardo Habkost, 2017/08/04
- [Qemu-devel] [PATCH for-2.11 4/5] qmp-shell: Accept QMP command as argument, Eduardo Habkost, 2017/08/04
- [Qemu-devel] [PATCH for-2.11 3/5] qmp-shell: execute_cmdargs() method, Eduardo Habkost, 2017/08/04
- [Qemu-devel] [PATCH for-2.11 5/5] Remove scripts/qmp/qmp, Eduardo Habkost, 2017/08/04
- [Qemu-devel] [PATCH for-2.11 1/5] qmp-shell: Use argparse module, Eduardo Habkost, 2017/08/04
- Re: [Qemu-devel] [PATCH for-2.11 1/5] qmp-shell: Use argparse module,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH for-2.11 2/5] qmp-shell: Pass split cmdargs to __build_cmd(), Eduardo Habkost, 2017/08/04
- Re: [Qemu-devel] [PATCH for-2.11 0/5] qmp-shell non-interactive mode, delete scripts/qmp/qmp, Fam Zheng, 2017/08/05
- Re: [Qemu-devel] [PATCH for-2.11 0/5] qmp-shell non-interactive mode, delete scripts/qmp/qmp, John Snow, 2017/08/07