[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 9/8] fixup! ppc: remove non implem
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 9/8] fixup! ppc: remove non implemented cpu models |
Date: |
Wed, 30 Aug 2017 16:44:53 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 30.08.2017 16:26, Igor Mammedov wrote:
> only TODO escaped defines were meant to be removed,
> but not TODO_USER_ONLY which are compiled in case of
> *-user targets.
>
> So retirn back "440" model removed by mistake
>
> Spotted-by: Thomas Huth <address@hidden>
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> target/ppc/cpu-models.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/target/ppc/cpu-models.c b/target/ppc/cpu-models.c
> index 611fc1b..08fb34b 100644
> --- a/target/ppc/cpu-models.c
> +++ b/target/ppc/cpu-models.c
> @@ -150,6 +150,10 @@
> POWERPC_DEF("x2vp20", CPU_POWERPC_X2VP20, 405,
> NULL)
> /* PowerPC 440 family
> */
> +#if defined(TODO_USER_ONLY)
> + POWERPC_DEF("440", CPU_POWERPC_440, 440GP,
> + "Generic PowerPC 440")
> +#endif
> /* PowerPC 440 cores
> */
> POWERPC_DEF("440-xilinx", CPU_POWERPC_440_XILINX, 440x5,
> "PowerPC 440 Xilinx 5")
>
With this fixup patch added:
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-devel] [PATCH v2 4/8] ppc: make cpu alias point only to real cpu models, (continued)
- [Qemu-devel] [PATCH v2 4/8] ppc: make cpu alias point only to real cpu models, Igor Mammedov, 2017/08/30
- [Qemu-devel] [PATCH v2 2/8] ppc: use macros to make cpu type name from string literal, Igor Mammedov, 2017/08/30
- [Qemu-devel] [PATCH v2 1/8] ppc: replace cpu_ppc_init() with cpu_generic_init(), Igor Mammedov, 2017/08/30
- [Qemu-devel] [PATCH v2 6/8] ppc: simplify cpu model lookup by PVR, Igor Mammedov, 2017/08/30
- [Qemu-devel] [PATCH v2 5/8] ppc: replace inter-function cyclic dependency/recurssion with 2 simple lookups, Igor Mammedov, 2017/08/30
- [Qemu-devel] [PATCH v2 7/8] ppc: drop caching ObjectClass from PowerPCCPUAlias, Igor Mammedov, 2017/08/30
- [Qemu-devel] [PATCH v2 8/8] ppc: remove non implemented cpu models, Igor Mammedov, 2017/08/30
- [Qemu-devel] [PATCH v2 3/8] ppc: make cpu_model translation to type consistent, Igor Mammedov, 2017/08/30