[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v8 07/13] qemu.py: close _qemu_log_path on cleanup
From: |
Amador Pahim |
Subject: |
[Qemu-devel] [PATCH v8 07/13] qemu.py: close _qemu_log_path on cleanup |
Date: |
Fri, 1 Sep 2017 13:28:23 +0200 |
We are opening the _qemu_log_path during the launch() but we are
forgetting to close it.
This patch makes sure we will close the self._qemu_log_path during the
cleanup (post_shutdown()).
Signed-off-by: Amador Pahim <address@hidden>
---
scripts/qemu.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/scripts/qemu.py b/scripts/qemu.py
index c26e1412f9..1b77fec48b 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -153,6 +153,9 @@ class QEMUMachine(object):
self._qmp.accept()
def _post_shutdown(self):
+ if self._qemu_log_fd is not None:
+ self._qemu_log_fd.close()
+
while self._created_files:
self._remove_if_exists(self._created_files.pop())
--
2.13.5
- Re: [Qemu-devel] [PATCH v8 04/13] qemu.py: improve message on negative exit code, (continued)
- [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create, Amador Pahim, 2017/09/01
- Re: [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create, Fam Zheng, 2017/09/04
- Re: [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create, Amador Pahim, 2017/09/14
- Re: [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create, Eduardo Habkost, 2017/09/14
- Re: [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create, Amador Pahim, 2017/09/14
- Re: [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create, Eduardo Habkost, 2017/09/14
- Re: [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create, Amador Pahim, 2017/09/14
- [Qemu-devel] [PATCH v8 05/13] qemu.py: include debug information on launch error, Amador Pahim, 2017/09/01
- [Qemu-devel] [PATCH v8 07/13] qemu.py: close _qemu_log_path on cleanup,
Amador Pahim <=
- [Qemu-devel] [PATCH v8 09/13] qemu.py: always cleanup on shutdown(), Amador Pahim, 2017/09/01
- [Qemu-devel] [PATCH v8 08/13] qemu.py: refactor launch(), Amador Pahim, 2017/09/01
- [Qemu-devel] [PATCH v8 10/13] qemu.py: use poll() instead of 'returncode', Amador Pahim, 2017/09/01
- [Qemu-devel] [PATCH v8 11/13] qemu.py: cleanup redundant calls in launch(), Amador Pahim, 2017/09/01
- [Qemu-devel] [PATCH v8 12/13] qemu.py: launch vm only if it's not running, Amador Pahim, 2017/09/01