Re: [Qemu-devel] [PATCH v19 0/2] virtio-crypto: virtio crypto device specification

[Longpeng (Mike)]

Hi Halil,

On 2017/9/1 19:45, Halil Pasic wrote:

> 
> 
> On 09/01/2017 02:47 AM, Longpeng (Mike) wrote:
>> Ping...
>>
>> Stefan, Halil, do you have any suggestion ?
>>
> 
> Hi Longpeng,
> 
> I've ran trough your patch, and it reads much better that
> what I recall v18 used to read like. Because it's been a while
> since v18 doing a conscious review on this will take a considerable
> amount of time (my memories of the issues identified back then
> are very sketchy/vague now). It's on my todo list, but it ain't the
> only item there.
> 


That's great, thanks :)

> Btw. I like to have a reference implementation at hand when reviewing
> a spec. What is the status of the (reference) implementation (I mean
> the new stuff like stateless/mux)? I think it would be nice to provide
> this info in the cover letter (e.g. next time, should we need another
> iteration).
> 


OK, I'll send a reference implementation based on the v19 spec next week.

> Regards,
> Halil
> 
> 
> .
> 


-- 
Regards,
Longpeng(Mike)