[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 10/13] qemu.py: use poll() instead of 'return
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v8 10/13] qemu.py: use poll() instead of 'returncode' |
Date: |
Tue, 5 Sep 2017 11:07:59 +0800 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Fri, 09/01 13:28, Amador Pahim wrote:
> The 'returncode' Popen attribute is not guaranteed to be updated. It
> actually depends on a call to either poll(), wait() or communicate().
>
> On the other hand, poll() will: "Check if child process has terminated.
> Set and return returncode attribute."
>
> Let's use the poll() to check whether the process is running and to get
> the updated process exit code, when the process is finished.
>
> Signed-off-by: Amador Pahim <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
- Re: [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create, (continued)
- [Qemu-devel] [PATCH v8 05/13] qemu.py: include debug information on launch error, Amador Pahim, 2017/09/01
- [Qemu-devel] [PATCH v8 07/13] qemu.py: close _qemu_log_path on cleanup, Amador Pahim, 2017/09/01
- [Qemu-devel] [PATCH v8 09/13] qemu.py: always cleanup on shutdown(), Amador Pahim, 2017/09/01
- [Qemu-devel] [PATCH v8 08/13] qemu.py: refactor launch(), Amador Pahim, 2017/09/01
- [Qemu-devel] [PATCH v8 10/13] qemu.py: use poll() instead of 'returncode', Amador Pahim, 2017/09/01
- Re: [Qemu-devel] [PATCH v8 10/13] qemu.py: use poll() instead of 'returncode',
Fam Zheng <=
- [Qemu-devel] [PATCH v8 11/13] qemu.py: cleanup redundant calls in launch(), Amador Pahim, 2017/09/01
- [Qemu-devel] [PATCH v8 12/13] qemu.py: launch vm only if it's not running, Amador Pahim, 2017/09/01
- [Qemu-devel] [PATCH v8 13/13] qemu.py: don't launch again before shutdown(), Amador Pahim, 2017/09/01
- Re: [Qemu-devel] [PATCH v8 00/13] scripts/qemu.py fixes and cleanups, Stefan Hajnoczi, 2017/09/05
- Re: [Qemu-devel] [PATCH v8 00/13] scripts/qemu.py fixes and cleanups, Eduardo Habkost, 2017/09/14