[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 0/3] watchdog: Allow setting action on the fl
From: |
Michal Privoznik |
Subject: |
Re: [Qemu-devel] [PATCH v4 0/3] watchdog: Allow setting action on the fly |
Date: |
Wed, 6 Sep 2017 17:41:15 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/06/2017 05:37 PM, Richard W.M. Jones wrote:
> On Wed, Sep 06, 2017 at 05:32:08PM +0200, Markus Armbruster wrote:
>> Series
>> Reviewed-by: Markus Armbruster <address@hidden>
>>
>> Perhaps Rich would like to have a look, too.
>
> I looked at them and they seemed OK but I didn't review them.
>
> I also added this comment on the bug which maybe relevant,
> maybe not ...
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1447169#c4
>
> "Not that it matters, but the real hardware was built into the
> southbridge and so not hotpluggable.
>
> Do you know what happens (or should happen) if the guest kernel
> loads the i6300esb driver with nowayout=1 and the hardware is
> unplugged? My reading of the driver says that this will not break
> or crash, although it probably won't work as the guest user
> expects. You can tell from the qemu side if the guest selected
> nowayout because ESB_WDT_LOCK is written to the ESB_LOCK_REG
> register.
>
> Anyway, this may not matter."
I've tested this and the guest continued running happily after I've
detached the watchdog.
Michal
- Re: [Qemu-devel] [PATCH v4 3/3] watchdog: Allow setting action on the fly, (continued)