[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 01/22] Revert "io: add new qio_channel_{readv
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v7 01/22] Revert "io: add new qio_channel_{readv, writev, read, write}_all functions" |
Date: |
Wed, 6 Sep 2017 11:09:12 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/06/2017 09:42 AM, Juan Quintela wrote:
> Eric Blake <address@hidden> wrote:
>> On 09/06/2017 06:51 AM, Juan Quintela wrote:
>>> This reverts commit d4622e55883211072621958d39ddaa73483d201e.
>>
>> But with no reason why? What bugs are you fixing by reverting this?
>
> I put it on the cover letter. I am investigating *why* it fails on me.
> It got the thread handed.
Then I think I ran into the same problems as you (NBD was hanging for me
due to the nested event loop being called from a coroutine context),...
>
> My plan is to fix whatever is there and see why it is failing.
>
>> Also, have you seen my patches, that also fix bugs in the _all functions?
>> https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg01053.html
>
> No, I have to take a look, thanks.
...and hopefully my patch helps the hang you were seeing (now in a pull
request:
https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg01338.html).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v7 00/22] Multifd, Juan Quintela, 2017/09/06
- [Qemu-devel] [PATCH v7 02/22] migration: Create migration_ioc_process_incoming(), Juan Quintela, 2017/09/06
- [Qemu-devel] [PATCH v7 01/22] Revert "io: add new qio_channel_{readv, writev, read, write}_all functions", Juan Quintela, 2017/09/06
- Re: [Qemu-devel] [PATCH v7 01/22] Revert "io: add new qio_channel_{readv, writev, read, write}_all functions", Eric Blake, 2017/09/06
- Re: [Qemu-devel] [PATCH v7 01/22] Revert "io: add new qio_channel_{readv, writev, read, write}_all functions", Juan Quintela, 2017/09/06
- Re: [Qemu-devel] [PATCH v7 01/22] Revert "io: add new qio_channel_{readv, writev, read, write}_all functions",
Eric Blake <=
- Re: [Qemu-devel] [PATCH v7 01/22] Revert "io: add new qio_channel_{readv, writev, read, write}_all functions", Daniel P. Berrange, 2017/09/06
- [Qemu-devel] [PATCH v7 03/22] migration: Teach it about G_SOURCE_REMOVE, Juan Quintela, 2017/09/06
- [Qemu-devel] [PATCH v7 04/22] migration: Add comments to channel functions, Juan Quintela, 2017/09/06
- [Qemu-devel] [PATCH v7 06/22] migration: Improve migration thread error handling, Juan Quintela, 2017/09/06
- [Qemu-devel] [PATCH v7 05/22] migration: Create migration_has_all_channels, Juan Quintela, 2017/09/06
- [Qemu-devel] [PATCH v7 07/22] migration: Make migrate_fd_error() the owner of the Error, Juan Quintela, 2017/09/06