[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 6/8] migration: Reset rather than destroy main_thread
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[Qemu-devel] [PULL 6/8] migration: Reset rather than destroy main_thread_load_event |
Date: |
Wed, 6 Sep 2017 19:41:31 +0100 |
From: "Dr. David Alan Gilbert" <address@hidden>
migration_incoming_state_destroy doesn't really destroy, it cleans up.
After a loadvm it's called, but the loadvm command can be run twice,
and so destroying an init-once mutex breaks on the second loadvm.
Reported-by: Stafford Horne <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Tested-by: Stafford Horne <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
---
migration/migration.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/migration.c b/migration/migration.c
index 1a2b3ebd1a..9838ccc885 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -166,7 +166,7 @@ void migration_incoming_state_destroy(void)
mis->from_src_file = NULL;
}
- qemu_event_destroy(&mis->main_thread_load_event);
+ qemu_event_reset(&mis->main_thread_load_event);
}
static void migrate_generate_event(int new_state)
--
2.13.5
- [Qemu-devel] [PULL 0/8] migration queue, Dr. David Alan Gilbert (git), 2017/09/06
- [Qemu-devel] [PULL 1/8] migration: Report when bdrv_inactivate_all fails, Dr. David Alan Gilbert (git), 2017/09/06
- [Qemu-devel] [PULL 3/8] host-utils: Proactively fix pow2floor(), switch to unsigned, Dr. David Alan Gilbert (git), 2017/09/06
- [Qemu-devel] [PULL 4/8] host-utils: Simplify pow2ceil(), Dr. David Alan Gilbert (git), 2017/09/06
- [Qemu-devel] [PULL 2/8] xbzrle: Drop unused cache_resize(), Dr. David Alan Gilbert (git), 2017/09/06
- [Qemu-devel] [PULL 5/8] runstate/migrate: Two more transitions, Dr. David Alan Gilbert (git), 2017/09/06
- [Qemu-devel] [PULL 7/8] snapshot/tests: Try loadvm twice, Dr. David Alan Gilbert (git), 2017/09/06
- [Qemu-devel] [PULL 6/8] migration: Reset rather than destroy main_thread_load_event,
Dr. David Alan Gilbert (git) <=
- [Qemu-devel] [PULL 8/8] migration: dump str in migrate_set_state trace, Dr. David Alan Gilbert (git), 2017/09/06
- Re: [Qemu-devel] [PULL 0/8] migration queue, Peter Maydell, 2017/09/07