Re: [Qemu-devel] [PATCH v4 09/20] instrument: Add basic control interface

[Emilio G. Cota]

On Wed, Sep 06, 2017 at 20:59:02 +0300, Lluís Vilanova wrote:
> Signed-off-by: Lluís Vilanova <address@hidden>
> ---
>  Makefile                           |    5 +++
>  configure                          |    1 +
>  instrument/Makefile.objs           |    2 +
>  instrument/control.c               |   28 +++++++++++++++++
>  instrument/control.h               |   44 +++++++++++++++++++++++++++
>  instrument/control.inc.h           |   25 ++++++++++++++++
>  instrument/error.h                 |   28 +++++++++++++++++
>  instrument/events.h                |   37 +++++++++++++++++++++++
>  instrument/events.inc.h            |   11 +++++++

Am I the only one who finds this control vs. events division confusing?

Also, do we need all these many files, even for the public API?

And why the .inc's?

Thanks,
                E.