[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/5] virtio-ccw: use ccw data stream
From: |
Halil Pasic |
Subject: |
Re: [Qemu-devel] [PATCH v3 3/5] virtio-ccw: use ccw data stream |
Date: |
Wed, 20 Sep 2017 12:56:16 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/20/2017 09:58 AM, Cornelia Huck wrote:
> On Tue, 19 Sep 2017 20:27:43 +0200
> Halil Pasic <address@hidden> wrote:
>
>> Replace direct access which implicitly assumes no IDA
>> or MIDA with the new ccw data stream interface which should
>> cope with these transparently in the future.
>>
>> Signed-off-by: Halil Pasic <address@hidden>
>> Reviewed-by: Pierre Morel<address@hidden>
>> ---
>> hw/s390x/virtio-ccw.c | 157
>> +++++++++++++++-----------------------------------
>> 1 file changed, 46 insertions(+), 111 deletions(-)
>>
>
>> @@ -417,9 +382,9 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw)
>> /* Return zeroes if the guest supports more feature bits. */
>> features.features = 0;
>> }
>> - address_space_stl_le(&address_space_memory, ccw.cda,
>> - features.features, MEMTXATTRS_UNSPECIFIED,
>> - NULL);
>> + ccw_dstream_rewind(&sch->cds);
>> + cpu_to_le32s(&features.features);
>> + ccw_dstream_write(&sch->cds, features.features);
>> sch->curr_status.scsw.count = ccw.count - sizeof(features);
>
> Hm, didn't you want to convert these as well? Or do you plan to do it
> as an add-on patch?
>
I plan to do it as an add on patch.
>> ret = 0;
>> }
>
- Re: [Qemu-devel] [PATCH v3 4/5] 390x/css: introduce maximum data address checking, (continued)