[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1] kvm: drop wrong assertion creating problems
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH v1] kvm: drop wrong assertion creating problems with pflash |
|
Date: |
Thu, 21 Sep 2017 08:49:56 +0200 |
On Wed, 2017-09-20 at 16:50 +0200, David Hildenbrand wrote:
> pflash toggles mr->romd_mode. So this assert does not always hold.
>
> 1) a device was added with !mr->romd_mode, therefore effectively not
> creating a kvm slot as we want to trap every access (add = false).
> 2) mr->romd_mode was toggled on before remove it. There is now
> actually no slot to remove and the asser is wrong.
>
> So let's just drop the assert.
Works without any obvious bad side effects.
Tested-by: Gerd Hoffmann <address@hidden>
cheers,
Gerd