[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/4] chardev: use per-dev context for io_add_
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/4] chardev: use per-dev context for io_add_watch_poll |
Date: |
Fri, 22 Sep 2017 17:18:15 +0800 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, Sep 21, 2017 at 04:11:33PM +0200, Paolo Bonzini wrote:
> On 21/09/2017 08:35, Peter Xu wrote:
> > It was only passed in by chr_update_read_handlers(). However when
> > reconnect, we'll lose that context information. So if a chardev was
> > running on another context (rather than the default context, the NULL
> > pointer), it'll switch back to the default context if reconnection
> > happens. But, it should really stick to the old context.
> >
> > Convert all the callers of io_add_watch_poll() to use the internally
> > cached gcontext. Then the context should be able to survive even after
> > reconnections.
>
> Why keep the argument then?
Yeah it's in next patch. I see that this series has been queued
already. Thanks!
--
Peter Xu
- [Qemu-devel] [PATCH v2 0/4] chardev: support non-default gcontext, Peter Xu, 2017/09/21
- [Qemu-devel] [PATCH v2 1/4] chardev: new qemu_chr_be_update_read_handlers(), Peter Xu, 2017/09/21
- [Qemu-devel] [PATCH v2 2/4] chardev: add Chardev.gcontext field, Peter Xu, 2017/09/21
- [Qemu-devel] [PATCH v2 3/4] chardev: use per-dev context for io_add_watch_poll, Peter Xu, 2017/09/21
- [Qemu-devel] [PATCH v2 4/4] chardev: remove context in chr_update_read_handler, Peter Xu, 2017/09/21
- Re: [Qemu-devel] [PATCH v2 0/4] chardev: support non-default gcontext, Marc-André Lureau, 2017/09/21