[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] docker: add installation to build tests
|
From: |
Fam Zheng |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] docker: add installation to build tests |
|
Date: |
Mon, 25 Sep 2017 11:09:12 +0800 |
|
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Fri, 09/22 17:49, Paolo Bonzini wrote:
> diff --git a/tests/docker/common.rc b/tests/docker/common.rc
> index 6865689..1522aab 100755
> --- a/tests/docker/common.rc
> +++ b/tests/docker/common.rc
> @@ -36,3 +36,11 @@ build_qemu()
> $QEMU_SRC/configure $config_opts
> make $MAKEFLAGS
> }
> +
> +install_qemu()
> +{
> + make install $MAKEFLAGS DESTDIR=$PWD/=destdir
Why provide DESTDIR? build_qemu already has "--prefix=$INSTALL_DIR", can a
simple "make install $MAKEFLAGS" work? Is there a permission problem?
> + ret=$?
> + rm -rf $PWD/=destdir
Why is this cleanup needed given the container will go away anyway?
Fam