[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-arm] [PATCH v1 1/8] Replace all occurances of __F
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [Qemu-arm] [PATCH v1 1/8] Replace all occurances of __FUNCTION__ with __func__ |
Date: |
Wed, 27 Sep 2017 16:47:42 -0700 |
On 26 September 2017 at 06:32, Eric Blake <address@hidden> wrote:
> On 09/25/2017 07:08 PM, Alistair Francis wrote:
>> diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c
>> index 58005b6619..32687afced 100644
>> --- a/hw/arm/nseries.c
>> +++ b/hw/arm/nseries.c
>> @@ -463,7 +463,7 @@ static uint32_t mipid_txrx(void *opaque, uint32_t cmd,
>> int len)
>> uint8_t ret;
>>
>> if (len > 9) {
>> - hw_error("%s: FIXME: bad SPI word width %i\n", __FUNCTION__, len);
>> + hw_error("%s: FIXME: bad SPI word width %i\n", __func__, len);
>
> Not this patch's problem, but it would probably be simpler if hw_error()
> were a macro that automatically prefixed __func__, rather than making
> every caller have to supply it themselves.
I'm not sure there's a great deal of benefit to that change, because
use of hw_error() in new code is rarely correct (it does an abort()
so it should never be used for guest-triggered conditions, which is
about the only time that you might be interested in a guest register
dump rather than just asserting). Most of its existing uses are in
crufty old device models.
thanks
-- PMM
- [Qemu-devel] [PATCH v1 7/8] tcg: Replace fprintf(stderr, "*\n" with error_report(), (continued)
- [Qemu-devel] [PATCH v1 7/8] tcg: Replace fprintf(stderr, "*\n" with error_report(), Alistair Francis, 2017/09/25
- [Qemu-devel] [PATCH v1 4/8] block: Replace fprintf(stderr, "*\n" with error_report(), Alistair Francis, 2017/09/25
- [Qemu-devel] [PATCH v1 6/8] ui: Replace fprintf(stderr, "*\n" with error_report(), Alistair Francis, 2017/09/25
- [Qemu-devel] [PATCH v1 8/8] target: Replace fprintf(stderr, "*\n" with error_report(), Alistair Francis, 2017/09/25
- [Qemu-devel] [PATCH v1 1/8] Replace all occurances of __FUNCTION__ with __func__, Alistair Francis, 2017/09/25
- [Qemu-devel] [PATCH v1 2/8] tests: Replace fprintf(stderr, "*\n" with error_report(), Alistair Francis, 2017/09/25
- [Qemu-devel] [PATCH v1 3/8] hw: Replace fprintf(stderr, "*\n" with error_report(), Alistair Francis, 2017/09/25
- Re: [Qemu-devel] [PATCH v1 0/8] Remove some of the fprintf(stderr, "*, no-reply, 2017/09/25