[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] websock: treat upgrade header in case insen
|
From: |
Daniel P. Berrange |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/1] websock: treat upgrade header in case insensitive way |
|
Date: |
Fri, 29 Sep 2017 17:19:45 +0100 |
|
User-agent: |
Mutt/1.9.0 (2017-09-02) |
On Fri, Sep 29, 2017 at 05:56:29PM +0300, Denis V. Lunev wrote:
> According to rfc6455 section 4.2.1. Reading the Client's Opening Handshake
> An |Upgrade| header field containing the value "websocket",
> treated as an ASCII case-insensitive value.
>
> Current implementation in QEMU accepts this header in lower-case only,
> which is revealed to have broken some real-life clients. We need to
> convert the value of this header to lower case before comparison.
> Unfortunately we can not do that for all headers. Only this specific one
> should be converted this way.
>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Daniel P. Berrange <address@hidden>
FYI, I already have a fix for this problem queued:
https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg02982.html
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|