|
| From: | Richard Henderson |
| Subject: | Re: [Qemu-devel] [PATCH 08/20] target/arm: Don't warn about exception return with PC low bit set for v8M |
| Date: | Thu, 5 Oct 2017 12:34:53 -0400 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/05/2017 12:32 PM, Richard Henderson wrote:
> if (env->regs[15] & 1) {
> if (!arm_feature(env, ARM_FEATURE_V8)) {
> qemu_log_mask(...);
> }
> env->regs[15] &= ~1U;
> }
Bah. Even better to move the bit clear statement before the feature check.
The two loads from env->regs[15] will no longer be separated by a function call
and therefore CSEd by the compiler.
r~
| [Prev in Thread] | Current Thread | [Next in Thread] |