Re: [Qemu-devel] [PATCH] tpm: Don't call tpm_cleanup unless CONFIG_TPM.

[Stefan Berger]

On 10/19/2017 03:50 AM, Richard W.M. Jones wrote:
> When compiling with --disable-tpm:
>
>    ../vl.o: In function `main':
>    /home/rjones/d/qemu/vl.c:4908: undefined reference to `tpm_cleanup'
>
> This appears to have been introduced in commit c37cacabf228
> ("tpm: Move tpm_cleanup() to right place").
>
> Signed-off-by: Richard W.M. Jones <address@hidden>

Reviewed-by: Stefan Berger <address@hidden>


> ---
>   vl.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/vl.c b/vl.c
> index 0723835bbf..dbfd06d4bc 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4905,7 +4905,9 @@ int main(int argc, char **argv, char **envp)
>       res_free();
>
>       /* vhost-user must be cleaned up before chardevs.  */
> +#ifdef CONFIG_TPM
>       tpm_cleanup();
> +#endif
>       net_cleanup();
>       audio_cleanup();
>       monitor_cleanup();