[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 2/9] migration: Don't play games with the requested c
|
From: |
Juan Quintela |
|
Subject: |
[Qemu-devel] [PULL 2/9] migration: Don't play games with the requested cache size |
|
Date: |
Sun, 29 Oct 2017 14:09:27 +0100 |
Now that we check that the value passed is a power of 2, we don't need
to play games when comparing what is the size that is going to take
the cache.
Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
---
migration/ram.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index 7f6327f708..42f3b7cb28 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -136,12 +136,14 @@ int64_t xbzrle_cache_resize(int64_t new_size, Error
**errp)
return -1;
}
+ if (new_size == migrate_xbzrle_cache_size()) {
+ /* nothing to do */
+ return new_size;
+ }
+
XBZRLE_cache_lock();
if (XBZRLE.cache != NULL) {
- if (pow2floor(new_size) == migrate_xbzrle_cache_size()) {
- goto out_new_size;
- }
new_cache = cache_init(new_size, TARGET_PAGE_SIZE, errp);
if (!new_cache) {
ret = -1;
@@ -152,8 +154,7 @@ int64_t xbzrle_cache_resize(int64_t new_size, Error **errp)
XBZRLE.cache = new_cache;
}
-out_new_size:
- ret = pow2floor(new_size);
+ ret = new_size;
out:
XBZRLE_cache_unlock();
return ret;
--
2.13.6
- [Qemu-devel] [PULL 0/9] Migration pull request, Juan Quintela, 2017/10/29
- [Qemu-devel] [PULL 3/9] migration: No need to return the size of the cache, Juan Quintela, 2017/10/29
- [Qemu-devel] [PULL 2/9] migration: Don't play games with the requested cache size,
Juan Quintela <=
- [Qemu-devel] [PULL 1/9] migration: Make sure that we pass the right cache size, Juan Quintela, 2017/10/29
- [Qemu-devel] [PULL 5/9] tests: rename postcopy-test to migration-test, Juan Quintela, 2017/10/29
- [Qemu-devel] [PULL 4/9] migration: Make xbzrle_cache_size a migration parameter, Juan Quintela, 2017/10/29
- [Qemu-devel] [PULL 6/9] tests: Refactor setting of parameters/capabilities, Juan Quintela, 2017/10/29
- [Qemu-devel] [PULL 7/9] tests: Factorize out migrate_test_start/end, Juan Quintela, 2017/10/29
- [Qemu-devel] [PULL 8/9] tests: Don't abuse global_qtest, Juan Quintela, 2017/10/29
- [Qemu-devel] [PULL 9/9] tests: check that migration parameters are really assigned, Juan Quintela, 2017/10/29
- Re: [Qemu-devel] [PULL 0/9] Migration pull request, Peter Maydell, 2017/10/30