Re: [Qemu-devel] [PATCH 5/5] nbd/server: refactor nbd_trip: split out nbd_handle_request

[Eric Blake]

On 03/08/2018 12:46 PM, Vladimir Sementsov-Ogievskiy wrote:
> Split out request handling logic.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
>   nbd/server.c | 129 +++++++++++++++++++++++++++++++----------------------------
>   1 file changed, 67 insertions(+), 62 deletions(-)

> +
> +    switch (request->type) {
> +    case NBD_CMD_READ:
> +        return nbd_do_cmd_read(client, request, data, errp);
> +
> +    case NBD_CMD_WRITE:
> +        flags = 0;
> +        if (request->flags & NBD_CMD_FLAG_FUA) {
> +            flags |= BDRV_REQ_FUA;
> +        }
> +        ret = blk_pwrite(exp->blk, request->from + exp->dev_offset,
> +                         data, request->len, flags);
> +
> +        return nbd_send_generic_reply(client, request->handle, ret,
> +                                      "writing to file failed", errp);
> +    case NBD_CMD_WRITE_ZEROES:

Inconsistent spacing between return and the next case label.

But switching whitespace is trivial, so

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org