Re: [Qemu-devel] [PATCH v2 15/17] cputlb: remove tb_lock from tlb_flush functions

[Richard Henderson]

On 04/05/2018 04:13 PM, Emilio G. Cota wrote:
> The acquisition of tb_lock was added when the async tlb_flush
> was introduced in e3b9ca810 ("cputlb: introduce tlb_flush_* async work.")
> 
> tb_lock was there to allow us to do memset() on the tb_jmp_cache's.
> However, since f3ced3c5928 ("tcg: consistently access cpu->tb_jmp_cache
> atomically") all accesses to tb_jmp_cache are atomic, so tb_lock
> is not needed here. Get rid of it.
> 
> Reviewed-by: Alex Bennée <address@hidden>
> Signed-off-by: Emilio G. Cota <address@hidden>
> ---
>  accel/tcg/cputlb.c | 8 --------
>  1 file changed, 8 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~