[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 05/12] monitor: no need to save need_resume
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PATCH 05/12] monitor: no need to save need_resume |
Date: |
Fri, 6 Jul 2018 14:13:47 +0200 |
There is no need for per-command need_resume granularity, it should
resume after running an non-oob command on oob-disabled monitor.
Signed-off-by: Marc-André Lureau <address@hidden>
---
monitor.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/monitor.c b/monitor.c
index 462cf96f7b..ec40a80d81 100644
--- a/monitor.c
+++ b/monitor.c
@@ -257,12 +257,6 @@ struct QMPRequest {
*/
QObject *req;
Error *err;
- /*
- * Whether we need to resume the monitor afterward. This flag is
- * used to emulate the old QMP server behavior that the current
- * command must be completed before execution of the next one.
- */
- bool need_resume;
};
typedef struct QMPRequest QMPRequest;
@@ -4079,11 +4073,13 @@ static void monitor_qmp_bh_dispatcher(void *data)
{
QMPRequest *req_obj = monitor_qmp_requests_pop_any();
QDict *rsp;
+ bool need_resume;
if (!req_obj) {
return;
}
+ need_resume = !qmp_oob_enabled(req_obj->mon);
if (req_obj->req) {
trace_monitor_qmp_cmd_in_band(qobject_get_try_str(req_obj->id) ?: "");
monitor_qmp_dispatch(req_obj->mon, req_obj->req, req_obj->id);
@@ -4094,7 +4090,7 @@ static void monitor_qmp_bh_dispatcher(void *data)
qobject_unref(rsp);
}
- if (req_obj->need_resume) {
+ if (need_resume) {
/* Pairs with the monitor_suspend() in handle_qmp_command() */
monitor_resume(req_obj->mon);
}
@@ -4146,7 +4142,6 @@ static void handle_qmp_command(JSONMessageParser *parser,
GQueue *tokens)
req_obj->id = id;
req_obj->req = req;
req_obj->err = err;
- req_obj->need_resume = false;
/* Protect qmp_requests and fetching its length. */
qemu_mutex_lock(&mon->qmp.qmp_queue_lock);
@@ -4159,7 +4154,6 @@ static void handle_qmp_command(JSONMessageParser *parser,
GQueue *tokens)
*/
if (!qmp_oob_enabled(mon)) {
monitor_suspend(mon);
- req_obj->need_resume = true;
} else {
/* Drop the request if queue is full. */
if (mon->qmp.qmp_requests->length >= QMP_REQ_QUEUE_LEN_MAX) {
--
2.18.0.rc1
[Qemu-devel] [PATCH 08/12] json-lexer: make it safe to call multiple times, Marc-André Lureau, 2018/07/06
[Qemu-devel] [PATCH 09/12] tests: add a few qemu-qmp tests, Marc-André Lureau, 2018/07/06