[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-3.0] pc: acpi: fix memhp regression by reduc
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH for-3.0] pc: acpi: fix memhp regression by reducing stub SRAT entry size |
Date: |
Mon, 30 Jul 2018 13:04:25 +0200 |
On Fri, 27 Jul 2018 16:50:31 +0200
Igor Mammedov <address@hidden> wrote:
> Commit 848a1cc1e (hw/acpi-build: build SRAT memory affinity structures for
> DIMM devices)
> broke the first dimm hotplug in following cases:
>
> 1: there is no coldplugged dimm in the last numa node
> but there is a coldplugged dimm in another node
>
> -m 4096,slots=4,maxmem=32G \
> -object memory-backend-ram,size=2G,id=m0 \
> -device pc-dimm,memdev=m0,node=1 \
> -object memory-backend-ram,id=m1,size=2G \
> -device pc-dimm,memdev=m1,node=0 \
> -numa node,nodeid=0 \
> -numa node,nodeid=1
>
> 2: if order of dimms on CLI is:
> 1st plugged dimm in node1
> 2nd plugged dimm in node0
>
> -m 4096,slots=4,maxmem=32G \
> -object memory-backend-ram,id=m1,size=2G \
> -device pc-dimm,memdev=m1,node=0 \
> -numa node,nodeid=0 \
> -numa node,nodeid=1
>
self-NACK on this one,
I've mixed up examples in commit message, it should have been other way around.
I've just posted v2 with fixed commit message
[...]