[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 07/21] block/create: utilize job_exit shim
From: |
John Snow |
Subject: |
[Qemu-devel] [PATCH 07/21] block/create: utilize job_exit shim |
Date: |
Tue, 7 Aug 2018 00:33:35 -0400 |
Utilize the job_exit shim by simply not calling job_defer_to_main_loop.
While we're here, we don't need to duplicate the core job object's `ret`.
Signed-off-by: John Snow <address@hidden>
---
block/create.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/block/create.c b/block/create.c
index 84bc74b7de..3aeafc68cf 100644
--- a/block/create.c
+++ b/block/create.c
@@ -34,26 +34,17 @@ typedef struct BlockdevCreateJob {
Job common;
BlockDriver *drv;
BlockdevCreateOptions *opts;
- int ret;
} BlockdevCreateJob;
-static void blockdev_create_complete(Job *job, void *opaque)
-{
- BlockdevCreateJob *s = container_of(job, BlockdevCreateJob, common);
-
- job_completed(job, s->ret);
-}
-
static void coroutine_fn blockdev_create_run(void *opaque)
{
BlockdevCreateJob *s = opaque;
job_progress_set_remaining(&s->common, 1);
- s->ret = s->drv->bdrv_co_create(s->opts, &s->common.err);
+ s->common.ret = s->drv->bdrv_co_create(s->opts, &s->common.err);
job_progress_update(&s->common, 1);
qapi_free_BlockdevCreateOptions(s->opts);
- job_defer_to_main_loop(&s->common, blockdev_create_complete, NULL);
}
static const JobDriver blockdev_create_job_driver = {
--
2.14.4
- [Qemu-devel] [PATCH 15/21] block/stream: add block job creation flags, (continued)
- [Qemu-devel] [PATCH 15/21] block/stream: add block job creation flags, John Snow, 2018/08/07
- [Qemu-devel] [PATCH 03/21] block/backup: utilize job_exit shim, John Snow, 2018/08/07
- [Qemu-devel] [PATCH 14/21] block/mirror: add block job creation flags, John Snow, 2018/08/07
- [Qemu-devel] [PATCH 10/21] tests/test-bdrv-drain: utilize job_exit shim, John Snow, 2018/08/07
- [Qemu-devel] [PATCH 19/21] qapi/block-commit: expose new job properties, John Snow, 2018/08/07
- [Qemu-devel] [PATCH 20/21] qapi/block-mirror: expose new job properties, John Snow, 2018/08/07
- [Qemu-devel] [PATCH 12/21] jobs: allow entrypoints to return status code, John Snow, 2018/08/07
- [Qemu-devel] [PATCH 07/21] block/create: utilize job_exit shim,
John Snow <=
- [Qemu-devel] [PATCH 06/21] block/stream: utilize job_exit shim, John Snow, 2018/08/07
- [Qemu-devel] [PATCH 04/21] block/commit: utilize job_exit shim, John Snow, 2018/08/07
- [Qemu-devel] [PATCH 01/21] jobs: canonize Error object, John Snow, 2018/08/07