[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 08/11] target/arm: Fix offset scaling for LD_zprr an
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH 08/11] target/arm: Fix offset scaling for LD_zprr and ST_zprr |
Date: |
Wed, 8 Aug 2018 20:40:30 -0700 |
The scaling should be solely on the memory operation size; the number
of registers being loaded does not come in to the initial computation.
Cc: address@hidden (3.0.1)
Reported-by: Laurent Desnogues <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
target/arm/translate-sve.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c
index f635822a61..d27bc8c946 100644
--- a/target/arm/translate-sve.c
+++ b/target/arm/translate-sve.c
@@ -4665,8 +4665,7 @@ static bool trans_LD_zprr(DisasContext *s, arg_rprr_load
*a, uint32_t insn)
}
if (sve_access_check(s)) {
TCGv_i64 addr = new_tmp_a64(s);
- tcg_gen_muli_i64(addr, cpu_reg(s, a->rm),
- (a->nreg + 1) << dtype_msz(a->dtype));
+ tcg_gen_shli_i64(addr, cpu_reg(s, a->rm), dtype_msz(a->dtype));
tcg_gen_add_i64(addr, addr, cpu_reg_sp(s, a->rn));
do_ld_zpa(s, a->rd, a->pg, addr, a->dtype, a->nreg);
}
@@ -4899,7 +4898,7 @@ static bool trans_ST_zprr(DisasContext *s, arg_rprr_store
*a, uint32_t insn)
}
if (sve_access_check(s)) {
TCGv_i64 addr = new_tmp_a64(s);
- tcg_gen_muli_i64(addr, cpu_reg(s, a->rm), (a->nreg + 1) << a->msz);
+ tcg_gen_shli_i64(addr, cpu_reg(s, a->rm), a->msz);
tcg_gen_add_i64(addr, addr, cpu_reg_sp(s, a->rn));
do_st_zpa(s, a->rd, a->pg, addr, a->msz, a->esz, a->nreg);
}
--
2.17.1
- [Qemu-devel] [PATCH 03/11] target/arm: Reorganize SVE WHILE, (continued)
- [Qemu-devel] [PATCH 03/11] target/arm: Reorganize SVE WHILE, Richard Henderson, 2018/08/08
- [Qemu-devel] [PATCH 04/11] target/arm: Fix typo in helper_sve_movz_d, Richard Henderson, 2018/08/08
- [Qemu-devel] [PATCH 05/11] target/arm: Fix typo in helper_sve_ld1hss_r, Richard Henderson, 2018/08/08
- [Qemu-devel] [PATCH 07/11] target/arm: Fix offset for LD1R instructions, Richard Henderson, 2018/08/08
- [Qemu-devel] [PATCH 06/11] target/arm: Fix sign-extension in sve do_ldr/do_str, Richard Henderson, 2018/08/08
- [Qemu-devel] [PATCH 08/11] target/arm: Fix offset scaling for LD_zprr and ST_zprr,
Richard Henderson <=
- [Qemu-devel] [PATCH 10/11] target/arm: Dump SVE state if enabled, Richard Henderson, 2018/08/08
- [Qemu-devel] [PATCH 09/11] target/arm: Reformat integer register dump, Richard Henderson, 2018/08/08
- [Qemu-devel] [PATCH 11/11] target/arm: Add sve-max-vq cpu property to -cpu max, Richard Henderson, 2018/08/08
- Re: [Qemu-devel] [PATCH 00/11] target/arm: sve linux-user patches, Peter Maydell, 2018/08/16