Re: [Qemu-devel] [PATCH 08/56] check-qjson: Streamline escaped_string()'s test strings

[Eric Blake]

On 08/08/2018 07:02 AM, Markus Armbruster wrote:
> Merge a few closely related test strings, and drop a few redundant
> ones.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>   tests/check-qjson.c | 14 ++------------
>   1 file changed, 2 insertions(+), 12 deletions(-)

>       } test_cases[] = {
> -        { "\\b", "\b" },
> -        { "\\f", "\f" },
> -        { "\\n", "\n" },
> -        { "\\r", "\r" },
> -        { "\\t", "\t" },
> -        { "/", "/" },
> -        { "\\/", "/", .skip = 1 },
> -        { "\\\\", "\\" },
> -        { "\\\"", "\"" },
> -        { "hello world \\\"embedded string\\\"",
> -          "hello world \"embedded string\"" },
> -        { "hello world\\nwith new line", "hello world\nwith new line" },
> +        { "\\b\\f\\n\\r\\t\\\\\\\"", "\b\f\n\r\t\\\"" },
> +        { "\\/\\'", "/'", .skip = 1 },

Aha - this adds coverage of the escaped ' not present in 7/56. (Still 
nothing about the unescaped versions of ' or " with correct quoting).

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org