[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qxl: drop unused generation variable
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] qxl: drop unused generation variable |
Date: |
Fri, 10 Aug 2018 14:26:16 +0100 |
On 10 August 2018 at 14:22, Gerd Hoffmann <address@hidden> wrote:
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> hw/display/qxl.h | 1 -
> hw/display/qxl.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/hw/display/qxl.h b/hw/display/qxl.h
> index 089696ef62..6eacba080d 100644
> --- a/hw/display/qxl.h
> +++ b/hw/display/qxl.h
> @@ -43,7 +43,6 @@ typedef struct PCIQXLDevice {
>
> enum qxl_mode mode;
> uint32_t cmdflags;
> - int generation;
> uint32_t revision;
>
> int32_t num_memslots;
> diff --git a/hw/display/qxl.c b/hw/display/qxl.c
> index 830c392c53..8e9135d9c6 100644
> --- a/hw/display/qxl.c
> +++ b/hw/display/qxl.c
> @@ -2057,7 +2057,6 @@ static void qxl_realize_common(PCIQXLDevice *qxl, Error
> **errp)
>
> qemu_spice_display_init_common(&qxl->ssd);
> qxl->mode = QXL_MODE_UNDEFINED;
> - qxl->generation = 1;
> qxl->num_memslots = NUM_MEMSLOTS;
> qemu_mutex_init(&qxl->track_lock);
> qemu_mutex_init(&qxl->async_lock);
> --
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM