|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH v3 23/23] libqtest: Rename qtest_FOOv() to qtest_vFOO() for consistency |
Date: | Sun, 12 Aug 2018 12:02:13 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 06/08/2018 08:53, Markus Armbruster wrote: > 13 of 13 C99 library function pairs taking ... or a va_list parameter > are called FOO() and vFOO(). In QEMU, we sometimes call the one > taking a va_list FOOv() instead. Bad taste. libqtest.h uses both > spellings. Normalize it to the standard spelling. Probably the bad example here was g_strdupv and g_strjoinv. Those however are taking a NULL-terminated char** [1] so the example was copied incorrectly. Paolo [1] In this case, it's NULL not NUL. :)
[Prev in Thread] | Current Thread | [Next in Thread] |