[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH] vl: fix migration when watchdog expires
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH] vl: fix migration when watchdog expires |
Date: |
Tue, 14 Aug 2018 14:02:12 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 14/08/2018 13:52, Dr. David Alan Gilbert wrote:
> a) Should the watchdog expire when the VM is stopped; I think it
> shouldn't - hw/acpi/tco.c uses a virtual timer as does i6300esb; so
> is the bug here that the watchdog being used didn't use a virtual
> timer?
All watchdogs do.
> b) If the watchdog expires just before the VM gets stopped, is there
> a race which could hit this? Possibly.
Yes, I think it is a race that happens just before vm_stop, but I don't
understand why the "qemu_clock_enable" in pause_all_vcpus does not
prevent it.
It should be possible to write a deterministic testcase with qtest...
Paolo
- [Qemu-devel] [RFC PATCH] vl: fix migration when watchdog expires, Jay Zhou, 2018/08/14
- Re: [Qemu-devel] [RFC PATCH] vl: fix migration when watchdog expires, Paolo Bonzini, 2018/08/14
- Re: [Qemu-devel] [RFC PATCH] vl: fix migration when watchdog expires, Dr. David Alan Gilbert, 2018/08/14
- Re: [Qemu-devel] [RFC PATCH] vl: fix migration when watchdog expires,
Paolo Bonzini <=
- Re: [Qemu-devel] [RFC PATCH] vl: fix migration when watchdog expires, Zhoujian (jay), 2018/08/14
- Re: [Qemu-devel] [RFC PATCH] vl: fix migration when watchdog expires, Paolo Bonzini, 2018/08/14
- Re: [Qemu-devel] [RFC PATCH] vl: fix migration when watchdog expires, Zhoujian (jay), 2018/08/14
- Re: [Qemu-devel] [RFC PATCH] vl: fix migration when watchdog expires, Zhoujian (jay), 2018/08/16
- Re: [Qemu-devel] [RFC PATCH] vl: fix migration when watchdog expires, Paolo Bonzini, 2018/08/17
- Re: [Qemu-devel] [RFC PATCH] vl: fix migration when watchdog expires, Dr. David Alan Gilbert, 2018/08/17
- Re: [Qemu-devel] [RFC PATCH] vl: fix migration when watchdog expires, Zhoujian (jay), 2018/08/14